k8snetworkplumbingwg / sriov-cni

DPDK & SR-IOV CNI plugin
Apache License 2.0
298 stars 147 forks source link

Support vlan Proto #277

Closed mlguerrero12 closed 9 months ago

mlguerrero12 commented 1 year ago

This allows users to set the vlan protocol.

This depends on https://github.com/vishvananda/netlink/pull/888

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6394477514


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/netlink_manager.go 0 2 0.0%
pkg/sriov/sriov.go 4 7 57.14%
pkg/utils/mocks/netlink_manager_mock.go 5 8 62.5%
<!-- Total: 31 39 79.49% -->
Files with Coverage Reduction New Missed Lines %
pkg/utils/mocks/netlink_manager_mock.go 1 84.56%
pkg/utils/netlink_manager.go 1 0.0%
pkg/sriov/sriov.go 2 37.62%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 6063244640: 2.6%
Covered Lines: 463
Relevant Lines: 1118

💛 - Coveralls
SchSeba commented 1 year ago

/hold

mlguerrero12 commented 10 months ago

@SchSeba, @adrianchiris, netlink PR got merged. This one is now ready. Please have a look when you have time.

mlguerrero12 commented 9 months ago

(added vlanProto in configuration reference)

@SchSeba, @zeeke, @Eoghan1232, could you please have a look at this? Thanks.

zeeke commented 9 months ago

LGTM