Bump to 1.22.4 - Githubissues

k8snetworkplumbingwg / sriov-cni

DPDK & SR-IOV CNI plugin

Apache License 2.0

298 stars 147 forks source link

Bump to 1.22.4 #302

Closed bn222 closed 3 weeks ago

Eoghan1232 commented 3 weeks ago

can we also bump versions in actions too?

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9742380449

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.554%

Totals
Change from base Build 9379725701:	0.0%
Covered Lines:	680
Relevant Lines:	1319

💛 - Coveralls

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 9742405189

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.554%

Totals
Change from base Build 9379725701:	0.0%
Covered Lines:	680
Relevant Lines:	1319

💛 - Coveralls

Eoghan1232 commented 3 weeks ago

CI fails on e2e tests - is this on an e2e environment? @zeeke @bn222 @SchSeba

zeeke commented 3 weeks ago

Project Dockerfile is based on golang:alpine, which happens to point to go1.22.4

https://github.com/k8snetworkplumbingwg/sriov-cni/blob/master/Dockerfile#L1

go: ../../go.mod requires go >= 1.22.4 (running go 1.22.2; GOTOOLCHAIN=local)
make: *** [Makefile:59: /usr/src/sriov-cni/build/sriov] Error 1
Error: building at STEP "RUN apk add --no-cache --virtual build-dependencies build-base=~0.5 &&     make clean &&     make build": while running runtime: exit status 2

@bn222 can you find an newer golang image?

SchSeba commented 3 weeks ago

I bump the image in the CI machines manually it should not support 1.22.4 lets see the CI lane