Refactor SriovNetwork and SriovIBNetwork controllers to use same code

k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin

Apache License 2.0

85 stars 114 forks source link

Closed ykulazhenkov closed 8 months ago

ykulazhenkov commented 8 months ago

Controllers were refactoring to use genericNetworkReconciler, which contains all logic

This is necessary to make it easier to add new controllers.

github-actions[bot] commented 8 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 8 months ago

153 of 189 (80.95%) changed or added relevant lines in 4 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 37.643%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
controllers/generic_network_controller.go	125	161	77.64%
<!--	Total:	153	189	80.95%	-->

Files with Coverage Reduction	New Missed Lines	%
controllers/drain_controller.go	1	70.36%
pkg/client/clientset/versioned/typed/sriovnetwork/v1/fake/fake_sriovnetworknodestate.go	2	48.65%
pkg/daemon/daemon.go	3	48.01%
<!--	Total:	6	-->

ykulazhenkov commented 8 months ago

used by #646

ykulazhenkov commented 8 months ago

@zeeke @SchSeba Could you please review this PR? :) Thx!