Change system dependencies for "post" systemd service

k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin

Apache License 2.0

85 stars 114 forks source link

Change system dependencies for "post" systemd service #680

Closed ykulazhenkov closed 7 months ago

ykulazhenkov commented 7 months ago

This is required to be compatible with OVS installations that use SysV init scripts (wrapped with systemd-sysv-generator). On such systems, OVS depends on the network-online.target, so the start order of services changes (OVS will start after the "post" service). The proposed solution is to add the following explicit dependencies

After: openvswitch-switch.service Before: kubelet.service.

Note: the dependency is ignored if the openvswitch-switch.service is not found.

cc @e0ne @SchSeba @zeeke

github-actions[bot] commented 7 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8662475929

Details

0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.001%) to 38.401%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/host/internal/service/service.go	0	5	0.0%
<!--	Total:	0	5	0.0%	-->

Files with Coverage Reduction	New Missed Lines	%
pkg/host/internal/service/service.go	1	16.67%
<!--	Total:	1		-->

Totals
Change from base Build 8605771976:	-0.001%
Covered Lines:	4807
Relevant Lines:	12518

💛 - Coveralls

github-actions[bot] commented 7 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] commented 7 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.