Let "depoly-setup.sh" and "undeploy.sh" fail on error

k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin

Apache License 2.0

85 stars 114 forks source link

Let "depoly-setup.sh" and "undeploy.sh" fail on error #686

Closed thom311 closed 3 months ago

thom311 commented 7 months ago

Ignoring errors seems not best. It can make it harder to find problems with the script.

If a command in the script is known to fail for valid reasons, then that should be treated specially (for example, with || :). By default, treat any unexpected failure as fatal and propagate the failure to the caller.

Fixes: 88441502023d ('Add RBAC for cluster resource')

CC: @pliurh

github-actions[bot] commented 7 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8755557051

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 38.404%

Totals
Change from base Build 8738593529:	0.02%
Covered Lines:	4817
Relevant Lines:	12543

💛 - Coveralls

SchSeba commented 3 months ago

Hi @thom311 can you please do a force push I am not able to trigger the k8s lane for some reason

adrianchiris commented 3 months ago

/test-all

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10455381530

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 44.999%

Totals
Change from base Build 10454628601:	0.0%
Covered Lines:	6533
Relevant Lines:	14518

💛 - Coveralls

SchSeba commented 3 months ago

all green merging nice work!