k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
84 stars 114 forks source link

Remove webhook validation for InfiniBand and RDMA #709

Closed e0ne closed 4 months ago

e0ne commented 5 months ago

Since we always deploy both mutation and validating webhooks there is no need to validate policy for InfiniBand and RDMA enabled because mutating webhook will wet 'isRdma' flag to 'true' for InfiniBand'.

github-actions[bot] commented 5 months ago

Thanks for your PR, To run vendors CIs use one of:

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9403579953

Details


Totals Coverage Status
Change from base Build 9402838972: 0.009%
Covered Lines: 5175
Relevant Lines: 13047

💛 - Coveralls
SchSeba commented 5 months ago

is it bad if we have this validation here? the mutation webhook is coming before the validation webhook so we should be ok here no?

e0ne commented 5 months ago

is it bad if we have this validation here? the mutation webhook is coming before the validation webhook so we should be ok here no?

mutation webhook is always executed before validating, so it means we've got dead code: the statement will be always false

e0ne commented 5 months ago

Here is admission controller documentation: https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#admission-control-phases

SchSeba commented 4 months ago

failing CI lane is not related to this change