Closed e0ne closed 4 months ago
Thanks for your PR, To run vendors CIs use one of:
/test-all
: To run all tests for all vendors./test-e2e-all
: To run all E2E tests for all vendors./test-e2e-nvidia-all
: To run all E2E tests for NVIDIA vendor.
To skip the vendors CIs use one of:
/skip-all
: To skip all tests for all vendors./skip-e2e-all
: To skip all E2E tests for all vendors./skip-e2e-nvidia-all
: To skip all E2E tests for NVIDIA vendor.
Best regards.Totals | |
---|---|
Change from base Build 9402838972: | 0.009% |
Covered Lines: | 5175 |
Relevant Lines: | 13047 |
is it bad if we have this validation here? the mutation webhook is coming before the validation webhook so we should be ok here no?
is it bad if we have this validation here? the mutation webhook is coming before the validation webhook so we should be ok here no?
mutation webhook is always executed before validating, so it means we've got dead code: the statement will be always false
Here is admission controller documentation: https://kubernetes.io/docs/reference/access-authn-authz/admission-controllers/#admission-control-phases
failing CI lane is not related to this change
Since we always deploy both mutation and validating webhooks there is no need to validate policy for InfiniBand and RDMA enabled because mutating webhook will wet 'isRdma' flag to 'true' for InfiniBand'.