add sort for the policy on the sriovOperatorConfig controller

k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin

Apache License 2.0

85 stars 114 forks source link

add sort for the policy on the sriovOperatorConfig controller #721

Closed SchSeba closed 5 months ago

SchSeba commented 5 months ago

we need to be consistent with the policy order

github-actions[bot] commented 5 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9633221770

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.07%) to 38.686%

Files with Coverage Reduction	New Missed Lines	%
controllers/sriovnetworkpoolconfig_controller.go	6	63.7%
<!--	Total:	6		-->

Totals
Change from base Build 9549902217:	0.07%
Covered Lines:	5187
Relevant Lines:	13408

💛 - Coveralls

github-actions[bot] commented 5 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9673856840

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.005%) to 40.38%

Files with Coverage Reduction	New Missed Lines	%
controllers/generic_network_controller.go	5	74.53%
<!--	Total:	5		-->

Totals
Change from base Build 9667839529:	0.005%
Covered Lines:	5457
Relevant Lines:	13514

💛 - Coveralls

github-actions[bot] commented 5 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

github-actions[bot] commented 5 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9698175400

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.08%) to 40.454%

Files with Coverage Reduction	New Missed Lines	%
controllers/generic_network_controller.go	5	74.53%
<!--	Total:	5		-->

Totals
Change from base Build 9691456203:	0.08%
Covered Lines:	5467
Relevant Lines:	13514

💛 - Coveralls

github-actions[bot] commented 5 months ago

Thanks for your PR, To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9699223239

Details

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
17 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.04%) to 40.621%

Files with Coverage Reduction	New Missed Lines	%
pkg/apply/apply.go	2	67.21%
controllers/helper.go	6	69.47%
controllers/sriovoperatorconfig_controller.go	9	63.76%
<!--	Total:	17	-->

Totals
Change from base Build 9699181042:	0.04%
Covered Lines:	5520
Relevant Lines:	13589