chore: remove vendor directory

[tobiasgiese]

Switched to Go modules for dependency management. This simplifies our workflow and reduces repo size.

[github-actions[bot]]

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.

• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

  To skip the vendors CIs, Maintainers can use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

[adrianchiris]

/test-all

[bn222]

if CI is green, I'm also on board with this

[tobiasgiese]

Having issues with controller-gen

go: gopkg.in/check.v1@v0.0.0-20161208181325-20d25e280405: missing go.sum entry for go.mod file

Added gopkg.in/check.v1 to hack/tools.go already but with no lock. Also the exact version is in the go.sum already.

[tobiasgiese]

@adrianchiris @bn222 FYI - had to add export GOPATH=$(shell go env GOPATH) to the Makefile, otherwise the GH runners downloaded all the deps to the repos go/. Also removed the obsolete vendor tests in https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/739/commits/f81700e08f2bc7b10161ada79bb2eccd120c9877

Edit: test k8s failed because of flakiness during cert-manager apply from remote

[adrianchiris]

/test-all

[adrianchiris]

/test-all

[tobiasgiese]

/test-all

[tobiasgiese]

/test-all

[tobiasgiese]

/test-all

[tobiasgiese]

/test-all

[tobiasgiese]

/test-all

[zeeke]

hi @tobiasgiese , end-to-end lanes are failing because of:

running tests
+ which ginkgo
which: no ginkgo in (/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator:/root/opr-k8s2-1/data/_tool/go/1.22.4/x64/bin:/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/usr/local/go/bin:/usr/local/bin:/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator/bin)
+ '[' 1 -ne 0 ']'
++ mktemp -d
+ GINKGO_TMP_DIR=/tmp/tmp.ADYS4SOl1B
+ cd /tmp/tmp.ADYS4SOl1B
+ go mod init tmp
go: creating new go.mod: module tmp
+ go install -mod=readonly github.com/onsi/ginkgo/v2/ginkgo@v2.9.5
go: go: module cache not found: neither GOMODCACHE nor GOPATH is set
+ rm -rf /tmp/tmp.ADYS4SOl1B
+ echo 'Downloading ginkgo tool'
Downloading ginkgo tool
+ cd -
/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator
+ GOPATH=/go
+ JUNIT_OUTPUT=/tmp/artifacts
+ export PATH=/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator:/root/opr-k8s2-1/data/_tool/go/1.22.4/x64/bin:/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/usr/local/go/bin:/usr/local/bin:/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator/bin:/go/bin
+ PATH=/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator:/root/opr-k8s2-1/data/_tool/go/1.22.4/x64/bin:/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/usr/local/go/bin:/usr/local/bin:/root/opr-k8s2-1/data/sriov-network-operator/sriov-network-operator/bin:/go/bin
+ ginkgo -output-dir=/tmp/artifacts --junit-report unit_report.xml -v ./test/validation -- -report=/tmp/artifacts
./hack/run-e2e-conformance.sh: line 21: ginkgo: command not found
failed, retrying
running tests

Would you mind adding the following changes (or anything similar) to this PR? https://github.com/k8snetworkplumbingwg/sriov-network-operator/commit/dabec260a703af6a08f52d58769b9fb56bd417f1

[tobiasgiese]

I think the issue is that the GH Actions runner has no real home directory. Also go env GOPATH is empty. Maybe the issue are the srirov runners?

[tobiasgiese]

❯ go env GOPATH
/Users/tgiese/go/
❯ echo $GOPATH
/Users/tgiese/go/
❯ unset GOPATH
❯ go env GOPATH
/Users/tgiese/go
❯ export HOME=
❯ go env GOPATH

❯

Seems like the issue is really the empty $HOME

[tobiasgiese]

/test-e2e-nvidia-all

[tobiasgiese]

/test-e2e-nvidia-all

[tobiasgiese]

/test-e2e-nvidia-all

[tobiasgiese]

/test-e2e-nvidia-all

[tobiasgiese]

/test-e2e-nvidia-all was low on disk space, added 50G

[tobiasgiese]

/test-all

[tobiasgiese]

/test-e2e-nvidia-all

all tests are running now 👍🏻

[adrianchiris]

thanks for working on this one @tobiasgiese !! @zeeke PTAL, lets merge this one if you are happy with it.

[adrianchiris]

punching it ! 🚀