k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
84 stars 114 forks source link

Intel switchdev #757

Closed zeeke closed 2 months ago

zeeke commented 3 months ago

Ice driver supports creating VFs after the eSwitcMode is set to switchdev. This is different than the preferred way for mlx5 driver.

Add specific functions to configure eSwitchMode and SriovNumVFs for each driver.

Add a basic test to loop over all available devices and test if setting eSwitchMode: switchdev works.

github-actions[bot] commented 3 months ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 10612389872

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/host/internal/sriov/sriov.go 32 56 57.14%
<!-- Total: 32 56 57.14% -->
Totals Coverage Status
Change from base Build 10594418576: 0.03%
Covered Lines: 6628
Relevant Lines: 14711

💛 - Coveralls
Eoghan1232 commented 2 months ago

I will do a test of this

Eoghan1232 commented 2 months ago

worked like a charm @zeeke ;)

let me give the PR a review now then we should be good to merge

adrianchiris commented 2 months ago

Please hold off with merging this one id like to go over this pr by end of week

zeeke commented 2 months ago

Got approval from multiple sides, merging.