k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
85 stars 114 forks source link

sriov-network-operator v1.3.0 released but still shows 1.2.0 in Helm chart #762

Closed jslouisyou closed 3 months ago

jslouisyou commented 3 months ago

Hello, sriov-network-operator team.

It seems that sriov-network-operator v1.3.0 was released last month, but still shows v1.2.0 in here.

apiVersion: v2
name: sriov-network-operator-chart
version: 1.2.0
kubeVersion: '>= 1.16.0-0'
appVersion: 1.2.0
description: SR-IOV network operator configures and manages SR-IOV networks in the kubernetes cluster
type: application
keywords:
  - sriov
home: https://github.com/k8snetworkplumbingwg/sriov-network-operator
sources:
  - https://github.com/k8snetworkplumbingwg/sriov-network-operator

I'm not sure if it's fine to use the Helm chart from with v1.3.0 tag. Could you verify whether it's alright to use this?

Thanks!

SchSeba commented 3 months ago

Hi @adrianchiris I think we need to add the version update to the script right?

adrianchiris commented 3 months ago

we update image chart in-place before publish. so the chart in the published oci image should contain the correct info.

see: https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/9dbf2b1b5fd1ff7e836aff169b8aabf020a2840e/hack/release/chart-update.sh#L70

the chart in the proj is for dev purposes.

adrianchiris commented 3 months ago

let me submit PR to this project to update chart version to something generic like : v0.0.0-dev

adrianchiris commented 3 months ago

submitted #764

SchSeba commented 3 months ago

great thanks! closing this one