Delete webhooks when SriovOperatorConfig is deleted

k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin

Apache License 2.0

84 stars 114 forks source link

Delete webhooks when SriovOperatorConfig is deleted #779

Closed zeeke closed 1 month ago

zeeke commented 2 months ago

When a user deletes the default SriovOperatorConfig resource and tries to recreate it afterward, the operator webhooks returns the error:

Error from server (InternalError): error when creating "/tmp/opconfig.yml": Internal error occurred: failed calling webhook "operator-webhook.sriovnetwork.openshift.io": failed to call webhook: Post "https://operator-webhook-service.openshift-sriov-network-operator.svc:443/validating-custom-resource?timeout=10s": service "operator-webhook-service" not found

as the webhook configuration is still present, while the Service and the DaemonSet have been deleted.

Delete all the webhook configurations when the user deletes the default SriovOperatorConfig

github-actions[bot] commented 2 months ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10955652211

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

28 of 28 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 45.183%

Totals
Change from base Build 10935762250:	0.1%
Covered Lines:	6659
Relevant Lines:	14738

k8snetworkplumbingwg / sriov-network-operator

Delete webhooks when SriovOperatorConfig is deleted #779

Pull Request Test Coverage Report for Build 10955652211

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls