k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
84 stars 114 forks source link

CI: Add a bash linter to pre-submits #781

Closed mandre closed 1 month ago

mandre commented 1 month ago

Add a new CI job that warns about shellcheck issues with severity error, and fix all such errors in existing bash files.

This should prevent errors such as the one fixed in https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/780 from entering the repo again.

github-actions[bot] commented 1 month ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11249043430

Details


Totals Coverage Status
Change from base Build 11248365096: 0.02%
Covered Lines: 6659
Relevant Lines: 14751

💛 - Coveralls
ykulazhenkov commented 1 month ago

The CI failure is not related (should be fixed by https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/785)