k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
85 stars 114 forks source link

metrics: Fix `Metrics should have the correct labels` test #785

Closed zeeke closed 1 month ago

zeeke commented 1 month ago

sriov_kubepoddevice metric might end up in the Prometheus database after a while, as the default scrape interval is 30s. This leads to failures in the end-to-end lane like:

[sriov] Metrics Exporter When Prometheus operator is available [It] Metrics should have the correct labels
/root/opr-ocp2-1/data/sriov-network-operator/sriov-network-operator/test/conformance/tests/test_exporter_metrics.go:132

  [FAILED] no value for metric sriov_kubepoddevice

Put the metric assertion in an Eventually statement

github-actions[bot] commented 1 month ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11229233629

Details


Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 68.06%
controllers/generic_network_controller.go 5 74.38%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 11212485228: -0.04%
Covered Lines: 6658
Relevant Lines: 14751

💛 - Coveralls