k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
84 stars 114 forks source link

Clean Systemd files on exit #792

Closed souleb closed 1 month ago

souleb commented 1 month ago

We have run into an issue where removing the operator leaves behind the systemd files.

If implemented all systemD related files will be cleaned up on exit on non openshift distributions.

github-actions[bot] commented 1 month ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

souleb commented 1 month ago

cc @e0ne

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 11341895365

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 10 15 66.67%
cmd/sriov-network-config-daemon/start.go 0 37 0.0%
<!-- Total: 10 52 19.23% -->
Files with Coverage Reduction New Missed Lines %
controllers/drain_controller.go 1 68.06%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 11294509064: -0.05%
Covered Lines: 6669
Relevant Lines: 14831

💛 - Coveralls