k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
84 stars 114 forks source link

Rdma subsytem mode #799

Closed SchSeba closed 1 week ago

github-actions[bot] commented 3 weeks ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11723997336

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/daemon.go 0 3 0.0%
pkg/host/internal/lib/netlink/netlink.go 0 3 0.0%
pkg/daemon/writer.go 0 7 0.0%
api/v1/zz_generated.deepcopy.go 2 12 16.67%
pkg/helper/mock/mock_helper.go 10 21 47.62%
controllers/sriovnetworknodepolicy_controller.go 0 12 0.0%
pkg/host/internal/network/network.go 19 31 61.29%
pkg/host/mock/mock_host.go 0 21 0.0%
controllers/helper.go 50 74 67.57%
pkg/plugins/generic/generic_plugin.go 65 97 67.01%
<!-- Total: 158 293 53.92% -->
Files with Coverage Reduction New Missed Lines %
pkg/daemon/daemon.go 1 44.58%
pkg/plugins/generic/generic_plugin.go 2 64.86%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 11613650922: 0.2%
Covered Lines: 6880
Relevant Lines: 15080

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

SchSeba commented 3 weeks ago

about

Did a first round of review. Overall approach looks good, though the GenericPlugin is starting to become a little complicated

you are right I think we probably can add a kernel/host/driver plugin or something like that will only handle that part and leave the generic one with only creating VFs

I can try to work on that for a following PR