Closed SchSeba closed 1 week ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/daemon/daemon.go | 0 | 3 | 0.0% | ||
pkg/host/internal/lib/netlink/netlink.go | 0 | 3 | 0.0% | ||
pkg/daemon/writer.go | 0 | 7 | 0.0% | ||
api/v1/zz_generated.deepcopy.go | 2 | 12 | 16.67% | ||
pkg/helper/mock/mock_helper.go | 10 | 21 | 47.62% | ||
controllers/sriovnetworknodepolicy_controller.go | 0 | 12 | 0.0% | ||
pkg/host/internal/network/network.go | 19 | 31 | 61.29% | ||
pkg/host/mock/mock_host.go | 0 | 21 | 0.0% | ||
controllers/helper.go | 50 | 74 | 67.57% | ||
pkg/plugins/generic/generic_plugin.go | 65 | 97 | 67.01% | ||
<!-- | Total: | 158 | 293 | 53.92% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/daemon/daemon.go | 1 | 44.58% | ||
pkg/plugins/generic/generic_plugin.go | 2 | 64.86% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 11613650922: | 0.2% |
Covered Lines: | 6880 |
Relevant Lines: | 15080 |
Thanks for your PR, To run vendors CIs, Maintainers can use one of:
/test-all
: To run all tests for all vendors./test-e2e-all
: To run all E2E tests for all vendors./test-e2e-nvidia-all
: To run all E2E tests for NVIDIA vendor.
To skip the vendors CIs, Maintainers can use one of:
/skip-all
: To skip all tests for all vendors./skip-e2e-all
: To skip all E2E tests for all vendors./skip-e2e-nvidia-all
: To skip all E2E tests for NVIDIA vendor.
Best regards.about
Did a first round of review. Overall approach looks good, though the GenericPlugin is starting to become a little complicated
you are right I think we probably can add a kernel/host/driver plugin or something like that will only handle that part and leave the generic one with only creating VFs
I can try to work on that for a following PR
Thanks for your PR, To run vendors CIs, Maintainers can use one of:
/test-all
: To run all tests for all vendors./test-e2e-all
: To run all E2E tests for all vendors./test-e2e-nvidia-all
: To run all E2E tests for NVIDIA vendor.To skip the vendors CIs, Maintainers can use one of:
/skip-all
: To skip all tests for all vendors./skip-e2e-all
: To skip all E2E tests for all vendors./skip-e2e-nvidia-all
: To skip all E2E tests for NVIDIA vendor. Best regards.