Closed EmilienM closed 2 days ago
Thanks for your PR, To run vendors CIs, Maintainers can use one of:
/test-all
: To run all tests for all vendors./test-e2e-all
: To run all E2E tests for all vendors./test-e2e-nvidia-all
: To run all E2E tests for NVIDIA vendor.
To skip the vendors CIs, Maintainers can use one of:
/skip-all
: To skip all tests for all vendors./skip-e2e-all
: To skip all E2E tests for all vendors./skip-e2e-nvidia-all
: To skip all E2E tests for NVIDIA vendor.
Best regards.Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
controllers/helper.go | 1 | 68.75% | ||
controllers/generic_network_controller.go | 5 | 74.38% | ||
<!-- | Total: | 6 | --> |
Totals | |
---|---|
Change from base Build 11775378543: | -0.02% |
Covered Lines: | 6874 |
Relevant Lines: | 15080 |
LGTM!
Hi @EmilienM can you take a quick look on the failed in the ocp lane please
please take a look on the helm deployment
In the context of Hypershift (Hosted Clusters with OpenShift), where a Nodepool (terminology for a worker Node in HCP) is not a control-plane or a master Node but a worker, we can't force the Operator to be deployed on a master node that doesn't exist. Instead, we want to deploy it on a worker.
The proposal here is to relax the rule and use
preferredDuringSchedulingIgnoredDuringExecution
instead so the scheduler will try to find a master node or fallback on other nodes if not found.