k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin
Apache License 2.0
84 stars 114 forks source link

deploy: relax Operator node affinity #806

Closed EmilienM closed 2 days ago

EmilienM commented 1 week ago

In the context of Hypershift (Hosted Clusters with OpenShift), where a Nodepool (terminology for a worker Node in HCP) is not a control-plane or a master Node but a worker, we can't force the Operator to be deployed on a master node that doesn't exist. Instead, we want to deploy it on a worker.

The proposal here is to relax the rule and use preferredDuringSchedulingIgnoredDuringExecution instead so the scheduler will try to find a master node or fallback on other nodes if not found.

github-actions[bot] commented 1 week ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11894643215

Details


Files with Coverage Reduction New Missed Lines %
controllers/helper.go 1 68.75%
controllers/generic_network_controller.go 5 74.38%
<!-- Total: 6 -->
Totals Coverage Status
Change from base Build 11775378543: -0.02%
Covered Lines: 6874
Relevant Lines: 15080

💛 - Coveralls
wizhaoredhat commented 1 week ago

LGTM!

SchSeba commented 5 days ago

Hi @EmilienM can you take a quick look on the failed in the ocp lane please

SchSeba commented 5 days ago

please take a look on the helm deployment

https://github.com/k8snetworkplumbingwg/sriov-network-operator/blob/aecb4bb904f21c3da98e0163c461c0dc940183b9/deployment/sriov-network-operator-chart/values.yaml#L10-L24