Add waitForDevicesInitialization to systemd service

k8snetworkplumbingwg / sriov-network-operator

Operator for provisioning and configuring SR-IOV CNI plugin and device plugin

Apache License 2.0

85 stars 114 forks source link

Add waitForDevicesInitialization to systemd service #808

Open ykulazhenkov opened 4 days ago

ykulazhenkov commented 4 days ago

Add waitForDevicesInitialization to systemd service.

This function ensures that the network devices specified in the configuration are registered and handled by UDEV. Sometimes, the initialization of network devices might take a significant amount of time, and the sriov-config systemd service may start before the devices are fully processed, leading to failure.

github-actions[bot] commented 4 days ago

Thanks for your PR, To run vendors CIs, Maintainers can use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:
/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor. Best regards.

coveralls commented 4 days ago

Pull Request Test Coverage Report for Build 11957819658

Details

40 of 55 (72.73%) changed or added relevant lines in 4 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 47.144%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cmd/sriov-network-config-daemon/service.go	22	27	81.48%
pkg/host/mock/mock_host.go	0	10	0.0%
<!--	Total:	40	55	72.73%	-->

Files with Coverage Reduction	New Missed Lines	%
controllers/helper.go	1	69.6%
controllers/generic_network_controller.go	5	74.38%
<!--	Total:	6	-->

Totals
Change from base Build 11931554664:	0.1%
Covered Lines:	7147
Relevant Lines:	15160

💛 - Coveralls

ykulazhenkov commented 14 hours ago

@SchSeba @zeeke Please, take a look on this PR