k8snetworkplumbingwg / whereabouts

A CNI IPAM plugin that assigns IP addresses cluster-wide
Apache License 2.0
273 stars 120 forks source link

Reconciler not reporting the actual failure when it fails to reconcile overlapping IP addresses #396

Open dougbtv opened 6 months ago

dougbtv commented 6 months ago

We output the error here: https://github.com/k8snetworkplumbingwg/whereabouts/blob/0d7d2be59005359f33ec2d67b0ab004f9c59f291/pkg/reconciler/iploop.go#L254

But... we don't actually report the error that happens here @ https://github.com/k8snetworkplumbingwg/whereabouts/blob/0d7d2be59005359f33ec2d67b0ab004f9c59f291/pkg/reconciler/iploop.go#L245C3-L246

We need to output the k8s error and not just the IP address that errored out, it makes this difficult to debug.