Update containernetworking deps

k8snetworkplumbingwg / whereabouts

A CNI IPAM plugin that assigns IP addresses cluster-wide

Apache License 2.0

282 stars 124 forks source link

Update containernetworking deps #408

Closed manuelbuil closed 7 months ago

manuelbuil commented 7 months ago

What this PR does / why we need it:

This PR updates to a newer version:

github.com/containernetworking/plugins
github.com/containernetworking/cni

There are a few changes that need to happen to start using the new versions:

Start using github.com/containernetworking/cni/pkg/types/040 instead of "current" because the latter does not exist anymore. Once this PR is merged, I'll work on another PR to migrate from 040 type to 100.
types020.SupportedVersions cannot be used anymore. Instead, I explicitely added the three values: """, "0.1.0", "0.2.0"

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # No issue. Should I create an issue?

Special notes for your reviewer (optional):

coveralls commented 7 months ago

Pull Request Test Coverage Report for Build 8003693108

Details

-1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.307%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pkg/config/config.go	0	1	0.0%
<!--	Total:	0	1	0.0%	-->

Totals
Change from base Build 7450424228:	0.0%
Covered Lines:	1141
Relevant Lines:	1578

💛 - Coveralls

manuelbuil commented 7 months ago

You must make peace with the linter; other than that, good to go. Thanks.

Isn't the linter part of the CI?

maiqueb commented 7 months ago

You must make peace with the linter; other than that, good to go. Thanks.

Isn't the linter part of the CI?

It is, I just checked this before seeing the CI results.

If you check the files changed tab you'll see the linter throws warnings in some files you've updated.

Still, warnings != errors.

manuelbuil commented 7 months ago

You must make peace with the linter; other than that, good to go. Thanks.

Isn't the linter part of the CI?

It is, I just checked this before seeing the CI results.

If you check the files changed tab you'll see the linter throws warnings in some files you've updated.

Still, warnings != errors.

Thanks, I did not see that. The lint warning is should have a package comment for package main and package config, which happens to be the files I changed. I can add one liner for each so that we don't see it again