k8snetworkplumbingwg / whereabouts

A CNI IPAM plugin that assigns IP addresses cluster-wide
Apache License 2.0
273 stars 120 forks source link

Bump net-attach to v1.7 #452

Closed manuelbuil closed 2 months ago

manuelbuil commented 2 months ago

What this PR does / why we need it:

Bump network-attachment-definition-client to v1.7.0.

It requires moving to skel.PluginMainFuncs instead of skel.PluginMain

Error: cmd/whereabouts.go:21:2: skel.PluginMain is deprecated: Use github.com/containernetworking/cni/pkg/skel.PluginMainFuncs instead.  (SA1019)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer (optional):

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 8689302289

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/whereabouts.go 0 35 0.0%
<!-- Total: 0 35 0.0% -->
Files with Coverage Reduction New Missed Lines %
cmd/whereabouts.go 2 46.99%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 8689276647: -0.4%
Covered Lines: 1136
Relevant Lines: 1578

💛 - Coveralls