Closed mlguerrero12 closed 1 month ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/reconciler/iploop.go | 20 | 26 | 76.92% | ||
cmd/whereabouts.go | 1 | 9 | 11.11% | ||
pkg/allocate/allocate.go | 0 | 10 | 0.0% | ||
<!-- | Total: | 21 | 45 | 46.67% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
pkg/allocate/allocate.go | 1 | 63.74% | ||
cmd/whereabouts.go | 2 | 46.34% | ||
<!-- | Total: | 3 | --> |
Totals | |
---|---|
Change from base Build 9076868168: | 0.2% |
Covered Lines: | 1130 |
Relevant Lines: | 1565 |
@mlguerrero12 It looks good to me. Just on a side note. Could you also change the function name of isPodAlive
? It's misleading. It should be something likeisOrphanedIP
.
@maiqueb, @pliurh, thanks for you comments. I addressed them. Please have a look again.
Fixes https://github.com/k8snetworkplumbingwg/whereabouts/issues/176