Return previous IP allocation for add cmd

k8snetworkplumbingwg / whereabouts

A CNI IPAM plugin that assigns IP addresses cluster-wide

Apache License 2.0

273 stars 120 forks source link

Return previous IP allocation for add cmd #471

Closed mlguerrero12 closed 2 weeks ago

mlguerrero12 commented 1 month ago

This allows the cni to return a previous allocation for a pod with the same podRef and interface name. This is needed on networks with limited IPs.
A new property called Interface was added on the API in order to uniquely identify allocations for pods with multiple interfaces.
Testing was improved and new cases (multiple interfaces and reclaim previous allocations) are added.
New field does not break backwards compatibility. Users that wish to solve the issue of limited ip reservations in statefulsets will have to recreate the pods to have this new field populated.

mlguerrero12 commented 1 month ago

@maiqueb, @dougbtv, @pliurh, please have a look when you have time. Thanks!

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9402269686

Details

5 of 22 (22.73%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 71.647%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
cmd/whereabouts.go	2	8	25.0%
pkg/allocate/allocate.go	3	14	21.43%
<!--	Total:	5	22	22.73%	-->

Totals
Change from base Build 9221798376:	-0.6%
Covered Lines:	1127
Relevant Lines:	1573

💛 - Coveralls

pliurh commented 1 month ago

@mlguerrero12 I can't find the code for updating the existing IP allocation records. Did you take care of that in this PR?

mlguerrero12 commented 3 weeks ago

@mlguerrero12 I can't find the code for updating the existing IP allocation records. Did you take care of that in this PR?

No, I decided not to add this functionality. It will be more overhead for little gain in my opinion. Everything will continue working, so it does not break backwards compatibility. Users that wish to solve the issue of limited ip reservations in statefulsets will have to recreate the pods to have this new field populated.