k8sonlab / publiccharts

Public Charts Monorepo
MIT License
2 stars 5 forks source link

Adds more extensive options for svc type LoadBalancer for the zwave ui chart #35

Closed wagnst closed 1 month ago

wagnst commented 1 month ago

This pull request updates the service.yaml template to improve the handling of different service types in the Helm chart for zwave-js-ui. The changes ensure that the correct configuration is applied based on the specified service type.

Enhancements to service type handling:

wagnst commented 1 month ago

@varet80 would be great if you could have a look and merge if ok. My values.yaml for this case would look like:

zwave-js-ui:

  service:
    type: LoadBalancer
    loadBalancerIP: 172.18.1.225
    externalTrafficPolicy: Local
varet80 commented 1 month ago

Thank you @wagnst. I added you as contributor, you can create branches directly to repo! and also make the testing/merging easier

wagnst commented 1 month ago

Thank you @wagnst. I added you as contributor, you can create branches directly to repo! and also make the testing/merging easier

i've just re-released the latest tag so this can be used, hope that is fine!

varet80 commented 1 month ago

All good!