search

k8sonlab / publiccharts

Public Charts Monorepo
MIT License
2 stars 5 forks source link

tls block for ingress on librephotos chart? #4

Closed loeken closed 2 years ago

loeken commented 2 years ago

was trying the chart and noticed there is no way to enable tls on the ingress usually i d expect something a long the lines of

  tls:
    {{- range $values.tls }}
    - hosts:
        {{- range .hosts }}
        - {{ tpl . $ | quote }}
        {{- end }}
      {{- if .secretName }}
      secretName: {{ tpl .secretName $ | quote}}
      {{- end }}
    {{- end }}
  {{- end }}

as part of the ingress and helm values something like 

ingress:
  ...
  tls:
  - secretName: librephotos-tls
    hosts:
    - librephotos.example.com

any plans to add?

varet80 commented 2 years ago

I can look into it. But also feel free to make a Pull request. As I use traefik, and their approach, did not use the tls in ingress. But makes sense to be supported

loeken commented 2 years ago

https://github.com/varet80/publiccharts/pull/5 sent over a PR

varet80 commented 2 years ago

I have merged your PR and also bumped the version to 202221 the new chart: 0.202221.0 should include the change.. currently been released

loeken commented 2 years ago

thanks, i tried rolling out the newly published version but im getting errors:

Error: parse error at (librephotos/templates/ingress.yaml:11): undefined variable "$values" Use --debug flag to render out invalid YAML
varet80 commented 2 years ago

5 minutes ago I published the .1! if you update your repo, fixes this one! I am busy with work! and had no time to test it. I need to add some linting and chart tests

I am busy adding more charts and also thinking to move on a helm-library style. to make it even easier to maintain

loeken commented 2 years ago

no worries I am in no rush :) - I too didnt test the PR i sent over yesterday either

bumping version to .1 seems to solve the issue, i can report nginx ingress/cert-manager issues me a cert successfully.

there seem to be some issue with default postgresql credentials as my backend container does not seem to be able to connect to the pg database. could it be that you mixed up username/passwords/database names along the way? i am a bit confused as to how you feed the db credentials - ideally i d like to feed them from secrets (sealed secrets)

    # -- Postgresql DB password
    dbUser: "{{ .Values.postgresql.auth.database }}"

feel free to respond when you're done with your work - dont let me distract you from work ;)

varet80 commented 2 years ago

Closing this, as the extra question belongs to another issue. issue: https://github.com/varet80/publiccharts/issues/8