k8ssandra / k8ssandra-operator

The Kubernetes operator for K8ssandra
https://k8ssandra.io/
Apache License 2.0
161 stars 75 forks source link

fix(main): SecretSyncController split namespaces #1400

Closed aGallea closed 3 weeks ago

aGallea commented 3 weeks ago

What this PR does: Splits WatchNamespaces when multiple namespaces provided (WATCH_NAMESPACE)

Which issue(s) this PR fixes: Fixes #1399

Checklist

aGallea commented 3 weeks ago

Initially opened this PR that caused the above 2 tests to fail:

unit/integration tests and build image / Run unit/integration tests multi-cluster e2e tests / RemoveDcFromCluster This seemed irrelevant to my changes, so I opened another PR with the same change to investigate further. However, this time, 3 different tests failed:

e2e tests / CreateSingleDseDatacenterCluster e2e tests / CreateSingleHcdDatacenterCluster e2e tests / PerNodeConfig/UserDefined

I'm looking for advice on how to proceed from here. Any guidance on how to debug or pinpoint the root cause would be appreciated.

burmanm commented 3 weeks ago

They were just flakes, I reran the tests.

burmanm commented 3 weeks ago

Any chance you could create CHANGELOG entry?

aGallea commented 3 weeks ago

Any chance you could create CHANGELOG entry?

Sure

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

aGallea commented 3 weeks ago

@burmanm Any chance you can rerun the failed checks please?

burmanm commented 3 weeks ago

Thanks for the PR.