search

k8ssandra / k8ssandra-operator

The Kubernetes operator for K8ssandra
https://k8ssandra.io/
Apache License 2.0
150 stars 72 forks source link

Vector for Cassandra should be enabled by default #968

Open adejanovski opened 1 year ago

adejanovski commented 1 year ago

Since cass-operator now uses Vector for the server-system-logger container, having to enable Vector through .cassandra.telemetry.vector.enabled doesn't make sense anymore.

We should consider that Vector is always enabled, which means that we'll have to duplicate the IsVectorEnabled() method into IsVectorEnabledForCassandra() which will return true if .cassandra.telemetry.vector.enabled is nil. The alternative would be to ignore the enabled field for Cassandra and consider Vector as always enabled.

adejanovski commented 1 year ago

@burmanm, wdyt?

burmanm commented 1 year ago

Well, one we could think of (if we want) is that you can actually also disable Vector in cass-operator (I forgot this), there's a Spec setting that allows disabling the ServerSystemLogger. That feature is not implemented at all in k8ssandra-operator I think, but would we want that ? So setting "enabled" explicitly to false would actually trigger removal of console logging? Not sure if users would understand that, but ..

adejanovski commented 1 year ago

I think that's a good idea. If it's properly documented (in the docs and in the CRD) then it does make sense 👍