search

k8ssandra / management-api-for-apache-cassandra

RESTful / Secure Management Sidecar for Apache Cassandra
Apache License 2.0
70 stars 51 forks source link

Add notification details to the repair process #338

Closed burmanm closed 1 year ago

burmanm commented 1 year ago

This provides a /api/v1 version of the /api/v0/ops/node/repair. Adds a new parameter to the Rpc method to indicate if the notifications should be received and stored in the job details.

The /api/v0/ops/node/repair was already async in execution, so /v1 simply adds the ability to follow notifications (and returns the job number to track it). Otherwise they're similar.

Fixes #342

Miles-Garnsey commented 1 year ago

Hi @burmanm, looks like we have failing tests so there are a few preliminary things to do here:

  1. Can we move these endpoints into v2 (all new endpoints are v2 at this point).
  2. We should be able to get these into the new client jar now that this PR is ready.
  3. There are failing tests, can you mark this as draft until it is passing?
  4. Please create an issue on this repo for tracking purposes.

Thanks!

burmanm commented 1 year ago

There are no v2 endpoints in the current mgmt-api master or any structures to them. And this is basically just v0, but added String return result (I was actually considering just changing v0, but since the meta has been v1 for these type of changes, this goes better with v1).

burmanm commented 1 year ago

I have no idea why the tests are not running without doing close/reopen.

emerkle826 commented 1 year ago

I have no idea why the tests are not running without doing close/reopen.

So this is the setup for the workflow: https://github.com/k8ssandra/management-api-for-apache-cassandra/actions/runs/5875182561/workflow#L3-L6

It should run on any commit push, or when a PR is opened or re-opened. I changed that recently as it would run CI twice on a commit push, which is a waste, once for the commit push, once for the update tho the PR. Maybe I'm not understanding how to set this up correctly....