search

k8ssandra / management-api-for-apache-cassandra

RESTful / Secure Management Sidecar for Apache Cassandra
Apache License 2.0
70 stars 51 forks source link

Integration tests for v1 endpoints #362

Closed emerkle826 closed 1 year ago

emerkle826 commented 1 year ago

We don't have many, but the Integration tests don't cover any of the v1 endpoints. We should write some where appropriate:

https://github.com/k8ssandra/management-api-for-apache-cassandra/blob/master/management-api-server/src/test/java/com/datastax/mgmtapi/BaseDockerIntegrationTest.java#L33-L35

Tests should cover the endpoints in the resources in the v1 package.

burmanm commented 1 year ago

We do?

NonDestructiveOpsIT.java: URIBuilder uriBuilder = new URIBuilder("http://localhost:8080/api/v1/ops/node/schema/versions"); NonDestructiveOpsIT.java: URIBuilder uriBuilder = new URIBuilder("http://localhost:8080/api/v1/ops/node/repair");

Rest are cases where we can't really test them, such as async decommission.

emerkle826 commented 1 year ago

I stand corrected. Closing this then.