Repair endpoint: Remove Optional and other objects not handled by RPC serialization

k8ssandra / management-api-for-apache-cassandra

RESTful / Secure Management Sidecar for Apache Cassandra

Apache License 2.0

72 stars 51 forks source link

Repair endpoint: Remove Optional and other objects not handled by RPC serialization #366

Closed Miles-Garnsey closed 1 year ago

Miles-Garnsey commented 1 year ago

Raising a PR so we can discuss the changes more easily.

github-actions[bot] commented 1 year ago

No linked issues found. Please add the corresponding issues in the pull request description.
Use GitHub automation to close the issue when a PR is merged

Miles-Garnsey commented 1 year ago

I'm going to merge this, the only area where we need to discuss further is:

repairSpec.put(RepairOption.JOB_THREADS_KEY, repairThreadCount.toString());

Where I think repairThreadCount I think should be an Integer, and we should leave unset if null or 0. I'll make that change in my branch once merged, and @emerkle826 can then confirm he's happy with it via review there.