Update ResourceInfo name datatype - Githubissues

k8stopologyawareschedwg / noderesourcetopology-api

This repository contains an implementation for CRD (https://docs.google.com/document/d/12kj3fK8boNuPNqob6F_pPU9ZTaNEnPGaXEooW1Cilwg/edit)

Apache License 2.0

8 stars 6 forks source link

Update ResourceInfo name datatype #2

Closed swatisehgal closed 3 years ago

swatisehgal commented 3 years ago

update from v1.ResourceName to string

Signed-off-by: Swati Sehgal swsehgal@redhat.com

swatisehgal commented 3 years ago

/hold

swatisehgal commented 3 years ago

/hold cancel

swatisehgal commented 3 years ago

@AlexeyPerevalov I added the vendor directory so that its straightforward to regenerate the code. Please let me know if you think it is okay to do so.

AlexeyPerevalov commented 3 years ago

I think we can add check for vendor directory and go mod vendor into hack/update-codegen.sh, instead of keeping it in git.

swatisehgal commented 3 years ago

Sure, updating the PR, will remove the vendor directory

swatisehgal commented 3 years ago

@AlexeyPerevalov Can we merge this now?