search

k8stopologyawareschedwg / resource-topology-exporter

Resource Topology exporter for Topology Aware Scheduler
Apache License 2.0
14 stars 12 forks source link

[release-0.16][manual] Limit serving of insecure metrics by allowing configurable IP #278

Closed swatisehgal closed 7 months ago

swatisehgal commented 7 months ago

This is a reimplementation of https://github.com/k8stopologyawareschedwg/resource-topology-exporter/pull/275 and https://github.com/k8stopologyawareschedwg/resource-topology-exporter/pull/280 on 0.16 branch to achieve the same end to end behavior.

Currently we are serving insecure metrics on all IPv4 routable addresses on the local machine (0.0.0.0).

In this PR, we make the metric IP configurable in order to ensure that we listen for insecure metrics port only on one IP to reduce security vulnerability.

ffromani commented 7 months ago

LGTM! But let's add the missing e2e test and let's backport it alongside this PR before to move forward

swatisehgal commented 7 months ago

Sure, no problem.