search

k8thekat / GatekeeperV2

Update to Gatekeeper
GNU General Public License v3.0
27 stars 11 forks source link

Lots of minor code and formatting improvements #26

Closed UncleThaodan closed 2 years ago

UncleThaodan commented 2 years ago

I highly, highly recommend using Autopep8 (ignoring rule E501). It keeps your formatting consistent and helps prevent certain bugs.

I fixed a whole bunch of formatting issues and made some minor improvements to the code. I also noticed a potential issue in AMP_cog.py at line 280 and marked it with a TODO.

The changes are all in individual commits to help with cherry-picking/noise.

k8thekat commented 2 years ago

Going to PR to a new branch for testing purpose. I want to look through the changes further and do testing as to not conflict with my "devtesting" branch.

Thank you for your PR

UncleThaodan commented 2 years ago

Do you mean the ones in a610030, 9457580 or both?

k8thekat commented 2 years ago

Any of the unused f-strings are fine in 94575, but remove the others please. Same goes for a610030

Thanks.

k8thekat commented 2 years ago

Thank you. Approving the PR.