search

k8up-io / k8up

Kubernetes and OpenShift Backup Operator
https://k8up.io/
Apache License 2.0
617 stars 63 forks source link

Helm Chart: Please allow service account annotations #875

Closed mkotsalainen closed 1 year ago

mkotsalainen commented 1 year ago

Summary

They are needed so that we can add IRSA roles to the service account

Context

You don't have support for annotations in your latest code

Out of Scope

No response

Further links

https://github.com/k8up-io/k8up/blob/master/charts/k8up/templates/serviceaccount.yaml

Acceptance Criteria

No response

Implementation Ideas

No response

mkotsalainen commented 1 year ago

Here's a PR For this: https://github.com/k8up-io/k8up/pull/876

I tried settings serviceAccount.create to false but that removes the ClusterRoleBinding so you'll need this if you want people to be able to use IRSA roles.

Kidswiss commented 1 year ago

Has been implemented via #877 and #879