k8up-io / k8up

Kubernetes and OpenShift Backup Operator
https://k8up.io/
Apache License 2.0
617 stars 63 forks source link

Fix indentation of the sa annotations #879

Closed Kidswiss closed 1 year ago

Kidswiss commented 1 year ago

Summary

Fixes issue found in: #876

Checklist

For Helm Chart changes

Kidswiss commented 1 year ago

@mkotsalainen can you test the branch from this PR? If that works for you I'll merge it.

mkotsalainen commented 1 year ago

This looks good! Thank you!

➜  k8up git:(fix/helm_indentation) helm template --debug --dry-run foo charts/k8up/ --set serviceAccount.annotations.qwer=asdf | grep asdf -B 10 -A10
install.go:200: [debug] Original chart version: ""
install.go:217: [debug] CHART PATH: /tmp/k8up/charts/k8up

apiVersion: v1
kind: ServiceAccount
metadata:
  name: foo-k8up
  labels:
    helm.sh/chart: k8up-4.4.1
    app.kubernetes.io/name: k8up
    app.kubernetes.io/instance: foo
    app.kubernetes.io/managed-by: Helm
  annotations:
    qwer: asdf
mkotsalainen commented 1 year ago

Tried installing also and it works.

➜  k8up git:(fix/helm_indentation) helm install -n foo foo charts/k8up/ --set serviceAccount.annotations.qwer=asdf
NAME: foo
LAST DEPLOYED: Mon Aug  7 09:31:25 2023
NAMESPACE: foo
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
#####################
! Attention !
#####################

This Helm chart does not include CRDs.
Please make sure you have installed or upgraded the necessary CRDs as instructed in the Chart README.

#####################
➜  k8up git:(fix/helm_indentation) k describe sa foo-k8up -n foo
Name:                foo-k8up
Namespace:           foo
Labels:              app.kubernetes.io/instance=foo
                     app.kubernetes.io/managed-by=Helm
                     app.kubernetes.io/name=k8up
                     helm.sh/chart=k8up-4.4.1
Annotations:         meta.helm.sh/release-name: foo
                     meta.helm.sh/release-namespace: foo
                     qwer: asdf
Image pull secrets:  <none>
Mountable secrets:   <none>
Tokens:              <none>
Events:              <none>
Kidswiss commented 1 year ago

Great! Merging and release.