k8up-io / k8up

Kubernetes and OpenShift Backup Operator
https://k8up.io/
Apache License 2.0
617 stars 63 forks source link

fix: Add values to overwrite cleanup image #890

Closed nheinemans-asml closed 11 months ago

nheinemans-asml commented 11 months ago

Summary

Adding new values to allow getting the cleanup image (bitnami/kubectl) from an internal registry. Solves issue #889

Checklist

For Helm Chart changes

Kidswiss commented 11 months ago

Hi @nheinemans-asml

Thanks for the contribution!

Can you please run make chart-docs and push that as well? That will genearte the docs for the new parameters.

Also the DCO is required for the PR checks to pass.

nheinemans-asml commented 11 months ago

Just one more thing, then it should be okay.

Almost there, I forgot to run make chart-docs after my last change.

Kidswiss commented 11 months ago

Just one more thing, then it should be okay.

Almost there, I forgot to run make chart-docs after my last change.

Yeah the readme still says hub.docker.com :)