k8up-io / k8up

Kubernetes and OpenShift Backup Operator
https://k8up.io/
Apache License 2.0
617 stars 63 forks source link

Add option to use a custom path inside an Azure Blob Storage Container #916

Closed l0wl3vel closed 8 months ago

l0wl3vel commented 8 months ago

Summary

Checklist

For Code changes

Kidswiss commented 8 months ago

Hi @l0wl3vel

Thanks for the contribution!

This looks sensible to me. I'll kick the e2e tests again, they are sometimes a by racy on github actions.

Once they pass I can approve and merge the change.

l0wl3vel commented 8 months ago

No, unfortunately not yet.

l0wl3vel commented 8 months ago

I just tested backing up with and without path field set and creating backups works as expected.

And as an aside: Is there existing code to run e2e tests against real infrastructure? I am only aware of the local kind+minio e2e tests.

l0wl3vel commented 8 months ago

@Kidswiss This is now ready to merge.

Kidswiss commented 8 months ago

And as an aside: Is there existing code to run e2e tests against real infrastructure? I am only aware of the local kind+minio e2e tests.

We currently only have the local minio/S3 tests automated.