k8up-io / k8up

Kubernetes and OpenShift Backup Operator
https://k8up.io/
Apache License 2.0
617 stars 63 forks source link

Helm Chart update: make executor ClusterRole name unique #925

Open bgounon opened 6 months ago

bgounon commented 6 months ago

Summary

Executor ClusterRole name should be dynamic instead of hard-coded. Without it, you cannot have several namespaced releases of k8up, as it triggers a collision on the executor ClusterRole name and fails.

Checklist

For Helm Chart changes

Kidswiss commented 6 months ago

Hi @bgounon

Thank you for the PR!

I like the idea, but just making the name dynamically based on the fullname could also break single installations, if a non-default name is specified.

Instead, you could add a new value under rbac like disableClusterRole. Then the first k8up install can install the clusterrole and all subsequent ones don't.

Another approach could be to disable the rbac completely and deploy the ClusterRoles separately, via the value rbac.create.