Open bgounon opened 6 months ago
Hi @bgounon
Thank you for the PR!
I like the idea, but just making the name dynamically based on the fullname could also break single installations, if a non-default name is specified.
Instead, you could add a new value under rbac
like disableClusterRole
. Then the first k8up install can install the clusterrole and all subsequent ones don't.
Another approach could be to disable the rbac completely and deploy the ClusterRoles
separately, via the value rbac.create
.
Summary
Executor ClusterRole name should be dynamic instead of hard-coded. Without it, you cannot have several namespaced releases of k8up, as it triggers a collision on the executor ClusterRole name and fails.
Checklist
For Helm Chart changes
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelogarea:chart
chart:k8up
make chart-docs