k8up-io / k8up

Kubernetes and OpenShift Backup Operator
https://k8up.io/
Apache License 2.0
617 stars 63 forks source link

BUG: Set rest server credentials in repository URL #927

Closed JcGKitten closed 6 months ago

JcGKitten commented 6 months ago

Summary

Adds the rest server credentials to the repository env variable by using the previously set credential env vars. Therefore it was needed to ensure that the "RESTIC_REPOSITORY" var is set after all the others, cause a map isn't ordered. This fixes #397.

Checklist

For Code changes

Kidswiss commented 6 months ago

HI @JcGKitten

Thanks for the PR! The code looks good to me.

Can you do a make fmt and then commit the changes? There's a trailing space in one of your comments that our linting caught.

JcGKitten commented 6 months ago

Hey @Kidswiss, thx for the review, sorry that I missed to run make fmt, pushed the formatted code.

Kidswiss commented 6 months ago

Thanks for your contribution! 🎉