k8up-io / k8up

Kubernetes and OpenShift Backup Operator
https://k8up.io/
Apache License 2.0
601 stars 62 forks source link

[enhancement] Adding new feature for supporting self-signed certificate #949

Closed poyaz closed 3 months ago

poyaz commented 4 months ago

Summary

Checklist

For Code changes

For Helm Chart changes

poyaz commented 3 months ago

Hi @poyaz

Thanks for this huge feature! Looks cool.

I haven't thoroughly reviewed it yet. Because unfortunately I have a problem with this PR: Your formatter did a lot of changes to the code. This makes reviewing this a lot harder. Also, your formatter style clashes with the formatting for the rest of the project.

Is it possible to adjust your formatter, so it conserves the old style?

Yeah, sorry for that I will fix my formatter and revert to old style