Closed poyaz closed 7 months ago
Hi @poyaz
Thanks for this huge feature! Looks cool.
I haven't thoroughly reviewed it yet. Because unfortunately I have a problem with this PR: Your formatter did a lot of changes to the code. This makes reviewing this a lot harder. Also, your formatter style clashes with the formatting for the rest of the project.
Is it possible to adjust your formatter, so it conserves the old style?
Yeah, sorry for that I will fix my formatter and revert to old style
Summary
--tls-client-cert
option)GO_EXEC
in Makefile to choose different versions of Golang (If the user installs multiply versions of Golang)Checklist
For Code changes
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelogarea:operator
charts/
directory.For Helm Chart changes
bug
,enhancement
,documentation
,change
,breaking
,dependency
as they show up in the changelogarea:chart
chart:k8up
make chart-docs