k8up-io / k8up

Kubernetes and OpenShift Backup Operator
https://k8up.io/
Apache License 2.0
601 stars 62 forks source link

feat: add security context for cleanup hook #966

Closed afrimberger closed 1 month ago

afrimberger commented 2 months ago

Summary

The operator deployment already supports setting podSecurityContext and securityContext. This PR allows setting both for the cleanup Job.

Checklist

For Helm Chart changes

TheBigLee commented 2 months ago

Hi @afrimberger Could you fix the DCO (sign the commit) so that all tests pass?

afrimberger commented 2 months ago

Hi @TheBigLee,

DCO is "green", now. Thanks for the hint.

I just looked at the Check list and didn't notice the red DCO build. Would be worth adding an entry "Commits signed off" to the Check list :).

TheBigLee commented 1 month ago

@afrimberger Can you run make chart-docs once more to fix the ChartLint check? once this is done, we'll merge this PR.

Cheers

TheBigLee commented 1 month ago

I just looked at the Check list and didn't notice the red DCO build. Would be worth adding an entry "Commits signed off" to the Check list :).

Thanks for the idea. We've added it to the checklist in #974

afrimberger commented 1 month ago

@TheBigLee : docs are updated and I added another small commit for fixing the labels for the Grafana Dashboard ConfigMap