k8up-io / wrestic

Restic Backup Kubernetes and OpenShift Wrapper - Part of K8up
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

[Bug] Webhooks no longer sent after completion of restore operation #75

Closed cdchris12 closed 3 years ago

cdchris12 commented 3 years ago

Describe the bug

During our testing of wrestic version 0.2.2, we discovered that webhooks are no longer fired by wrestic at the completion of a restore operation

Additional context

In version 0.1.9 of wrestic, webhooks were fired at the completion of each restore operation, with output looking like the following:

Removing locks...
created new cache in /root/.cache/restic
successfully removed locks
Listing snapshots
snapshots command:
30 Snapshots
Starting restore...
S3 chosen as restore destination
done!
Restore successful.
Removing locks...
Sending webhooks to <statsURL>: done

Logs

If applicable, add logs to help explain your problem.

I0310 22:27:36.123212 1 main.go:43] wrestic "level"=0 "msg"="Wrestic Version: v0.2.2-dirty"
I0310 22:27:36.123490 1 main.go:44] wrestic "level"=0 "msg"="Operator Build Date: Tue Mar 9 15:28:43 UTC 2021"
I0310 22:27:36.123504 1 main.go:45] wrestic "level"=0 "msg"="Go Version: go1.15.8"
I0310 22:27:36.123511 1 main.go:46] wrestic "level"=0 "msg"="Go OS/Arch: linux/amd64"
I0310 22:27:36.123518 1 main.go:194] wrestic "level"=0 "msg"="setting up a signal handler"
I0310 22:27:41.236791 1 snapshots.go:39] wrestic/snapshots "level"=0 "msg"="getting list of snapshots"
I0310 22:27:48.406077 1 restore.go:63] wrestic/restore "level"=0 "msg"="restore initialised"
I0310 22:27:48.406103 1 restore.go:68] wrestic/restore "level"=0 "msg"="loading all snapshots from repositoy"
I0310 22:27:48.406115 1 snapshots.go:39] wrestic/snapshots "level"=0 "msg"="getting list of snapshots"
I0310 22:27:49.947878 1 restore.go:197] wrestic/restore "level"=0 "msg"="S3 chosen as restore destination"
I0310 22:27:56.738419 1 restore.go:254] wrestic/restore "level"=0 "msg"="starting restore" "s3 filename"="<backup-name>-2021-03-10T22:23:34Z.tar.gz"
I0310 22:27:59.260968 1 restore.go:267] wrestic/restore "level"=0 "msg"="restore finished"

Expected behavior

At the completion of a backup, prune, or restore operation, wrestic should send a webhook with relevant information

To Reproduce

Steps to reproduce the behavior:

  1. Attempt to restore a backup using wrestic version 0.2.2
  2. Note that no webhook is sent at the completion of this operation

Environment (please complete the following information):