border-top issue when opening settings view

k9ordon / yosemite-unity-ui

An Atom theme for a more native experience on OS X 10.10 Yosemite - DEPRECATED

https://atom.io/themes/yosemite-unity-ui

MIT License

39 stars 6 forks source link

border-top issue when opening settings view #8

Closed k9ordon closed 10 years ago

k9ordon commented 10 years ago

Tabs loose border-top after opening settings view.

open atom
open some files (tabs have 1px border top)
open settings (tabs have no border top)
close settings (tabs still have no top border)

atom_tab_bordertop_bug

wilfreddenton commented 10 years ago

I was looking into this and it seems that the tabs do still have a border-top, they're just being pushed up. I added margin-top: 2px to the .tab-bar class in the dev tools and it bumped them back down into place. This of course is not a fix, but it's a step.

wilfreddenton commented 10 years ago

I was messing around with the .tab-bar class in the styles.less file and discovered that this problem is fixed by setting the height of the tab bar to 26px or greater, ex.

.tab-bar {
  height: 26px;
}

k9ordon commented 10 years ago

thx!