kHRISl33t / runtime-env-cra

Runtime environment handler for create-react-apps
MIT License
49 stars 23 forks source link

Fixed parsing OS specific EOLs #5

Closed seanblonien closed 3 years ago

seanblonien commented 3 years ago

Discovered that on Windows, it includes the '\r' character if you don't split by the correct line ending

Changed it to auto-detect the EOL and split the string accordingly

kHRISl33t commented 3 years ago

Can you please rebase with your other branch? Or update the other one with these changes and I can review it there.

seanblonien commented 3 years ago

Yea I can put it on the other branch

seanblonien commented 3 years ago

Re-based this branch onto branch with PR #6