Header-navbar integration + Layout

CatboardBox commented 1 year ago

Description

Integration of header by team A with mobile Navbar by Team C
Global Layout for web (still takes custom layouts set in the page into account)
user profile navigation link not added yet due to no further updates getting received

Header: Mobile Navbar: Included by default for every page: However, it has been excluded from some pages (can be configured). E.g. from login as it already has a custom header To exclude a page from having the global layout applied to it, just call the following code:

Page.ignoreHeader = true;

Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Issue fix (non-breaking change that addresses existing opened issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Refactoring change (refactoring change must not apply any form of functional change)

Fixes

Notion Task Coverage

Checklist

[x] Related issues linked using fixes #number. / There is no issue fix.
[x] Unit tests or E2E tests added for any new feature changes. / There is no new feature that requires test.
[x] Ensured that there's no linter errors.
[x] Ran the full set of testings and coverage reports exceed 80%. / There is currently no test.
[x] All Merge Conflicts have been fully resolved.
[x] Branch is rebased off the target branch.
[x] This PR is complete and does not have incomplete work that'll break the application.

CatboardBox commented 1 year ago

I think so, I did change most of the header to be dynamic /fixed the styling, but this behaviour was already there when i started working on that.

RuinedRuins commented 1 year ago

just fix the dropdown z index then since the client will see it

huishilhs commented 1 year ago

For my side, the header has a grey background, is that correct? because I saw your screenshot the bg is white.

CatboardBox commented 1 year ago

For my side, the header has a grey background, is that correct? because I saw your screenshot the bg is white.

Yes, I was experimenting with minor className changes as the original header was quite plain and boring. The header that you saw may not be the final one. But still do feel free to share any feedback that you might have

kKar1503 / project-inc-siwma-1