search

kLabUM / pystorms

Simulation Sandbox for the Design and Evaluation of Stormwater Control Algorithms
https://pystorms.netlify.app
GNU General Public License v3.0
30 stars 16 forks source link

Dependency Issues #2

Closed abhiramm7 closed 4 years ago

abhiramm7 commented 4 years ago

pyswmm or pyswmm_lite dependency needs clean up.

  1. Update the setup.py file to incorporate yaml and pyswmm/pyswmm_lite dependency
  2. Move over the environments.py file over to pystorms. This should make the transition seamless.
abhiramm7 commented 4 years ago

https://pyswmm.readthedocs.io/en/stable/reference/lib.html this might be the easiest way to handle this clash. pystorms can be shipped with custom binaries, which can then be used by scenarios as needed.

abhiramm7 commented 4 years ago

Actually, simulation object might be a easier fix. So updating the environment class with binary to use argument might work.

abhiramm7 commented 4 years ago

Was tricky than expected. Might be better to rethink the binary handling in pyswmm. We seem to be limiting the ease of shifting binaries.But its fixed.