search

kLabUM / rrcf

🌲 Implementation of the Robust Random Cut Forest algorithm for anomaly detection on streams
https://klabum.github.io/rrcf/
MIT License
488 stars 111 forks source link

Updates deprecated numpy conventions #95

Closed arrrrrmin closed 1 year ago

arrrrrmin commented 1 year ago

Fixes some older numpy conventions like np.int or np.asscalar. Used numpy version: 1.24.1

mdbartos commented 1 year ago

Thanks for this. The old CI based on Travis is no longer working, and will need to be re-implemented in Github actions. After that, I can pull in this request.

(Unless someone else with access wants to help enable CI via Github actions. Any interest @abhiramm7 😛?)

abhiramm7 commented 1 year ago

Haha, can do! @mdbartos

mdbartos commented 1 year ago

Hi @arrrrrmin, I added tests through Github actions:

https://github.com/kLabUM/rrcf/blob/master/.github/workflows/python-package.yml

Could you add this to your branch, so that these tests will run in this PR?

Thanks, MDB

arrrrrmin commented 1 year ago

Ok but for 

on:
  push:
    branches: [ "master" ]
  pull_request:
    branches: [ "master" ]

I need to change the PR`s target to kLabUM:master, are you fine with merging into master?

mdbartos commented 1 year ago

I can see that the tests have passed on your branch, so I am going to merge in and see if they pass here. I will follow up if I find any issues.

Thanks! MDB