search

kLabz / js-object

Haxe externs for Javascript Object and Symbol
MIT License
7 stars 1 forks source link

Merge into std #1

Open markknol opened 6 years ago

markknol commented 6 years ago

Would it be an idea to provide a PR to Haxe? We already have the externs, but not this nicely documented.

https://api.haxe.org/v/development/js/Object.html https://github.com/HaxeFoundation/haxe/blob/development/std/js/Object.hx

kLabz commented 6 years ago

Yep, that is a mid-term objective once these are battle tested.

I'm not sure how to handle ES2015+ & ES2017+ features in the std context, though.

markknol commented 6 years ago

Great! Btw do you mind if I do it myself? What specific ES2015+ & ES2017+ do you mean for example?

kLabz commented 6 years ago

Not at all :)

I mean the fields with "Note: this is an ES201[5|7] feature" in the comments, but I fear mostly for ES2017 fields (entries and values) since ES2015 is widespread now.

damoebius commented 6 years ago

@markknol I thought the js.html.* files are auto generated from the MDN. So we can't commit improvements. https://github.com/HaxeFoundation/haxe/pull/6507#issuecomment-321886609

kLabz commented 6 years ago

Exactly: js.html.* files, not js.*.

damoebius commented 6 years ago

Cool :)