search

kW-Labs / nmecr

An implementation of peer-reviewed energy data analysis algorithms for site-specific M&V
MIT License
24 stars 7 forks source link

TOWT predictions cannot predict negative values? #16

Closed Cyy-fresh1994 closed 1 year ago

Cyy-fresh1994 commented 1 year ago

We used the nmecr to predict annual normalized electricity consumption.

Our training data has a lot of negative values due to solar PV production. And the model fit by using training data can capture the negatives, see the screenshot below: image

But when we do predictions, the predictions are all positive, it looks like the negative values were cut off, see the screenshot below: image

Cannot nmecr be used for predicting negative data?

dexterluu commented 1 year ago

Hi,

Do you have data and code to replicate the issue? Seems like in the first plot the values can go negative so it doesn't appear to be an issue with the coefficients.

Thanks, Dexter

Cyy-fresh1994 commented 1 year ago

Yes, please see attached code and data. Thank you for the help.

Thank you, Yiyi

From: dexterluu @.> Sent: Friday, January 27, 2023 2:08 PM To: kW-Labs/nmecr @.> Cc: Chu, Yiyi @.>; Author @.> Subject: [EXTERNAL] Re: [kW-Labs/nmecr] TOWT predictions cannot predict negative values? (Issue #16)

This is an EXTERNAL email. Do not click links or open attachments unless you validate the sender and know the content is safe.

ALWAYS hover over the link to preview the actual URL/site and confirm its legitimacy.

Hi,

Do you have data and code to replicate the issue? Seems like in the first plot the values can go negative so it doesn't appear to be an issue with the coefficients.

Thanks, Dexter

- Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FkW-Labs%2Fnmecr%2Fissues%2F16%23issuecomment-1407022338&data=05%7C01%7CYChu%40trccompanies.com%7C137b3fd627b34c09bf1308db00a224e7%7C543eaf7b7e0d4076a34d1fc8cc20e5bb%7C0%7C0%7C638104468640172652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=puGfH6jDLeSrdXrwrV9vfnwQGhqUu%2By1fs3LhJQSDts%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAP4YTS2UXNVGK4O5AG7GYKTWUQTIZANCNFSM6AAAAAAUH3G35M&data=05%7C01%7CYChu%40trccompanies.com%7C137b3fd627b34c09bf1308db00a224e7%7C543eaf7b7e0d4076a34d1fc8cc20e5bb%7C0%7C0%7C638104468640172652%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=m0VqdiG77kYyf585NI6B1pCAKKxhnUXvz0vWzNMJ5wY%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

dexterluu commented 1 year ago

Sorry to have to ask again, but I don't think the attachments went through via email. Can you attach the files on the issue thread on GitHub?

Thanks, Dexter

Cyy-fresh1994 commented 1 year ago

Historical Meter 2.csv Historical temperature data.csv TMY2 Temp - San Fran.csv nmecr-demo - Copy.txt

The nmecr-demo file should be .rmd, but I cannot upload rmd files. Please change txt to be rmd before you open it.

Thank you, Yiyi

dexterluu commented 1 year ago

Hi Yiyi,

I updated the package and included an argument to allow for negative values in the calculate_model_predictions function. Please reinstall the package to get the change.

Thanks, Dexter