ka-extension / ka-extension-ts

A browser extension for Khan Academy.
MIT License
19 stars 11 forks source link

Center program titles and discussion #123

Closed MatthiasPortzel closed 6 years ago

MatthiasPortzel commented 6 years ago

I'm not OCD, but it bothers me when things aren't centered.

Before:

screen shot 2018-11-03 at 1 07 48 pm

After:

screen shot 2018-11-03 at 1 08 31 pm
JettBurns14 commented 6 years ago

KA moved program titles to the left side to match the rest of the headers on the site, which are all left aligned. I think centering the T&T is cool but Idk about the titles. Can you screenshot the centered titles?

lukekrikorian commented 6 years ago

image

This is what the change looks like. LGTM

MatthiasPortzel commented 6 years ago

It definitely makes sense to left align titles on pages like this, where the content is all left aligned. screen shot 2018-11-14 at 8 13 44 am

But on programs and projects, the only thing that fell along that line was the left side of discussion, which you can't see at the same time as the title most of the time (you have to scroll). And the extension moves the discussion box so it doesn't fall along that line either. Here's a picture without the extension:

screen shot 2018-11-14 at 8 10 51 am

Edit: To clarify, this change shouldn't touch articles, just project/program pages.

Edit: AH! This change does center the titles of articles. Let me see if I can fix that.

JettBurns14 commented 6 years ago

Ok, if you can get just the program titles centered I think it’s fine.