ka-extension / ka-extension-ts

A browser extension for Khan Academy.
MIT License
19 stars 11 forks source link

Editor settings #131

Closed MatthiasPortzel closed 5 years ago

MatthiasPortzel commented 5 years ago

This adds an Editor Settings popup which adds the ability to change a myriad (okay, 10) Ace options. It creates an editor-settings.ts file to house this code. This removes all dark-mode code, because we can now support as many themes as we want (I decided to start with 4). There are several pieces of code in project.ts that have been added to configure Ace's initial options to support both KA's setup and allow flexibility. The way this is set up, it's very easy to add more Ace options, so if anyone has requests, I can add them. And I know my CSS is bad; I welcome suggestions to improve it.

If at all possible, it's worth squashing this PR. Those 10 commits document the dramatic journey I took in converting the general Javascript I wrote into Typescript. They don't need to be in the project history.